Skip to content

Support schemas #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #30
nicolay-r opened this issue Feb 10, 2025 · 0 comments
Closed
Tracked by #30

Support schemas #28

nicolay-r opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Feb 10, 2025

UPD
I think it is even better option is to merge here
https://github.com/nicolay-r/bulk-ner/blob/main/bulk_ner%2Fapi.py#L48-L49
Because pipeline should not know about various inputs. So that, we just just stacking dicts and attempting to merge them with no intersections.

And this is where we refactoring horizontal batching:
https://github.com/nicolay-r/bulk-ner/blob/main/bulk_ner%2Fapi.py#L37

Old reasoning
I think we have to add grouping of the rows concept in the pipeline here
https://github.com/nicolay-r/bulk-ner/blob/main/bulk_ner%2Fapi.py#L23-L32
As the list item.
At present, supporting schemas would lead to amount of rows in output similar to n*c, where c is the total amount of columns

@nicolay-r nicolay-r added the enhancement New feature or request label Feb 10, 2025
@nicolay-r nicolay-r self-assigned this Feb 10, 2025
@nicolay-r nicolay-r mentioned this issue Feb 10, 2025
5 tasks
nicolay-r added a commit that referenced this issue Feb 15, 2025
nicolay-r added a commit that referenced this issue Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant