Skip to content

Add appearance-readonly to nimble-select and nimble-combobox #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 20, 2025

Conversation

mollykreis
Copy link
Contributor

@mollykreis mollykreis commented May 13, 2025

Pull Request

🀨 Rationale

Add appearance-readonly attribute to the nimble-select and nimble-combobox to style the components as readonly when they are disabled.

πŸ‘©β€πŸ’» Implementation

  • Add appearance-readonly attribute (tied to appearanceReadOnly property) on the select and combobox
  • Added styles to make disabled + appearanceReadOnly look like other readonly controls (neither select nor combobox has a readonly property or styles today)
  • Updated storybook docs
  • Updated matrix tests
    • As part of the matrix test updates, I split the select matrix story into 3 stories (one for each theme) because chromatic was timing out loading the story

πŸ§ͺ Testing

  • Manually tested
  • Chromatic test

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis marked this pull request as ready for review May 14, 2025 20:05
@mollykreis mollykreis enabled auto-merge (squash) May 20, 2025 20:57
@mollykreis mollykreis merged commit f137a31 into main May 20, 2025
13 checks passed
@mollykreis mollykreis deleted the select-appearance-readonly branch May 20, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants