Add appearance-readonly to nimble-select and nimble-combobox #2602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Add
appearance-readonly
attribute to thenimble-select
andnimble-combobox
to style the components as readonly when they are disabled.π©βπ» Implementation
appearance-readonly
attribute (tied toappearanceReadOnly
property) on the select and comboboxdisabled + appearanceReadOnly
look like other readonly controls (neither select nor combobox has areadonly
property or styles today)π§ͺ Testing
β Checklist