Improve EffectiveDistance precision in target bars #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EffectiveDistance is just a (rounded) byte and so is not that useful for determining exact distances from boss mechanics. This PR changes EffectiveDistance to be a float based on the Radius when on 6.x. For backwards compatibility, pre-6.x users will get the rounded byte. Belated thanks to @KattTails for the memory location for radius!
|
Thanks!! And sorry for the late merge. |
ngld
pushed a commit
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EffectiveDistance is just a (rounded) byte and so is not that useful
for determining exact distances from boss mechanics. This PR
changes EffectiveDistance to be a float based on the Radius when
on 6.x. For backwards compatibility, pre-6.x users will get the
rounded byte.
Belated thanks to @KattTails for the memory location for radius!