Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove announce for slack #3104

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Remove announce for slack #3104

merged 1 commit into from
Feb 6, 2025

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Feb 6, 2025

Proposed changes

Slack is no more.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner February 6, 2025 23:17
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (b6a51d1) to head (3c3b345).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3104   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         112      112           
  Lines       11570    11570           
  Branches       50       50           
=======================================
  Hits        10420    10420           
  Misses       1089     1089           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome enabled auto-merge (squash) February 6, 2025 23:21
@lucacome lucacome merged commit 01da5c7 into main Feb 6, 2025
40 checks passed
@lucacome lucacome deleted the chore/slack branch February 6, 2025 23:34
lucacome added a commit that referenced this pull request Feb 6, 2025
(cherry picked from commit 01da5c7)
lucacome added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants