-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add test-demo workflow #719
base: main
Are you sure you want to change the base?
Conversation
a904153
to
2ff99a5
Compare
Unrelated error messages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static analysis for the workflow using zizmor:
$ zizmor .github/workflows/test-demo.yaml
6 findings (4 suppressed): 0 unknown, 0 informational, 0 low, 2 medium, 0 high
test: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: 'actions/checkout@v4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See zizmor - artipacked audit rule
- uses: 'actions/checkout@v4' | |
- uses: 'actions/checkout@v4' | |
with: { persist-credentials: false } |
pull_request: | ||
branches: [ main ] | ||
workflow_dispatch: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See zizmor - excessive permissions audit rule
permissions: {} | |
78af612
to
b0042a2
Compare
Just found
|
5ba8f17
to
31d4a0f
Compare
635d2ae
to
b8a16b3
Compare
Debian 12 (latest stable), Ubuntu 24.04 (latest LTS) and Ubuntu 24.10 (latest release) is failing on
which is discussed here and here and might be caused by NixOS/nixpkgs#372931 . |
787da80
to
e09852b
Compare
The issue narrowed down to
|
|
|
Found the issue. Older Nix versions are containing this regression. Confirmed on Debian 12: # test.nix
let
pkgs = import (builtins.fetchTarball "https://github.com/nixos/nixpkgs/archive/nixos-unstable.tar.gz") {};
foo = pkgs.runCommand "foo" {} ''
mkdir -p $out/hi
'';
bar = pkgs.closureInfo {
rootPaths = [ "${foo}/hi" ];
};
in bar nix-build test.nix
these 2 derivations will be built:
/nix/store/6j38j4jw7hc85ivfm8lqzd68rs648lks-foo.drv
/nix/store/7pvpmra0wr45gfwk4nlm9l1zs964rp9n-closure-info.drv
building '/nix/store/6j38j4jw7hc85ivfm8lqzd68rs648lks-foo.drv'...
error: path '/nix/store/0sqhavfz16amb1bl97gpgc9ivddcafv6-foo/hi' is not in the Nix store |
89852f3
to
332735e
Compare
Can we get a newer Nix package on Debian? Or simply skip Debian for now and leave a TODO to pick up once their next stable release is out? |
3adbf08
to
ba80a2c
Compare
The issue is that it fails on Ubuntu LTS and on latest Ubuntu (non LTS) as well. |
This might be a bit too much, but can't we run a more recent Nix version using the Nix installed on those distros? |
Not sure if I understand. What exactly do you mean ? |
The issue is with old Nix versions, right? What if we use those to install/use a more recent Nix, say nixVersions.latest. That should be possible, right? |
da244bc
to
f60cad8
Compare
1f091e3
to
5a1d640
Compare
Looks like the regression patch was backported to multiple Nix versions . |
No, you can't change Nix version installed by Debian/Ubuntu that way. |
No description provided.