Skip to content

Commit cf00868

Browse files
authored
Merge pull request #2194 from nf-core/remove-sniffer
Remove dodgy sniffer code from samplesheet_check.py
2 parents 7f30502 + 6de786c commit cf00868

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
- Turn on automatic clean up of intermediate files in `work/` on successful pipeline completion in full-test config ([#2163](https://github.com/nf-core/tools/pull/2163)) [Contributed by @jfy133]
88
- Add documentation to `usage.md` on how to use `params.yml` files, based on nf-core/ampliseq text ([#2173](https://github.com/nf-core/tools/pull/2173/)) [Contributed by @jfy133, @d4straub]
99
- Make jobs automatically resubmit for a much wider range of exit codes (now `104` and `130..145`) ([#2170](https://github.com/nf-core/tools/pull/2170))
10+
- Remove problematic sniffer code in samplesheet_check.py that could give false positive 'missing header' errors ([https://github.com/nf-core/tools/pull/2194]) [Contributed by @Midnighter, @jfy133]
1011

1112
### Linting
1213

nf_core/pipeline-template/bin/check_samplesheet.py

-3
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,6 @@ def sniff_format(handle):
158158
peek = read_head(handle)
159159
handle.seek(0)
160160
sniffer = csv.Sniffer()
161-
if not sniffer.has_header(peek):
162-
logger.critical("The given sample sheet does not appear to contain a header.")
163-
sys.exit(1)
164161
dialect = sniffer.sniff(peek)
165162
return dialect
166163

0 commit comments

Comments
 (0)