Skip to content

JSON schema: Rnaseq #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
13 of 15 tasks
jen-reeve opened this issue Mar 26, 2025 · 0 comments · May be fixed by #1528
Open
13 of 15 tasks

JSON schema: Rnaseq #1531

jen-reeve opened this issue Mar 26, 2025 · 0 comments · May be fixed by #1528
Assignees

Comments

@jen-reeve
Copy link

  • Fork the pipeline to your user account, if you have not done so before (Make sure you deselect Copy the master branch only)
  • Go to the dev branch and sync the upstream changes (Sync fork -> Update branch)
  • Create a branch called json-schema-improvements with the dev branch as base in the fork
  • Open the json-schema-improvements branch of the fork either locally (git clone) or online (via Github Codespaces, GitPod...)
  • Open the nextflow_schema.json file
  • Check that the value in "$schema" is "https://json-schema.org/draft/2020-12/schema". The pipeline should be updated to nf-schema if this is not the case. See the migration guide on how to do this
  • Check the schema for insufficient validation keywords and error messages. See the guide for more information on this
  • Do the same thing for assets/schema_input.json
  • Run nextflow run main.nf -profile test,docker --outdir results -stub to check for any failures in validation with the basic test setup
  • Update the changelog of the pipeline
  • Push all changes to your fork (if you have not done so yet)
  • Open a pull request to the dev branch of the nf-core repository
  • Request a review in #hackathon-mar-2025-json-schema-improvements or in the pipeline channel (e.g. #sarek for nf-core/sarek) and set the issue status to Ready to review (PR: )
  • Wait for approval and merge the pull request once everything works again
  • Set the issue status to Done
@jen-reeve jen-reeve converted this from a draft issue Mar 26, 2025
@jen-reeve jen-reeve linked a pull request Mar 26, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging a pull request may close this issue.

2 participants