Arm profile platform should be linux/arm64

[birnbera]

Description of the bug

In #1425 config was added for ARM compatible docker images. However, in the corresponding arm profile, it still sets the docker platform as linux/amd64:

rnaseq/nextflow.config

Line 193 in b96a753

docker.runOptions = '-u $(id -u):$(id -g) --platform=linux/amd64'

Since arm.config references images that are ARM-only, when you try to run with the arm profile, you get errors from the docker engine, like:

docker: image with reference community.wave.seqera.io/library/grep_sed_tar:4b2523b1c76a5494 was found but does not match the specified platform: wanted linux/amd64, actual: linux/arm64.

Getting rid of the extra docker.runOptions from the arm profile fixes the issue.

Command used and terminal output

Relevant files

No response

System information

No response

[birnbera]

I'd be happy to make this simple PR. If I should, would it be considered a patch PR to master since it's technically a bug in the released version or would I make a PR against dev? Also, for patches, the instructions to bump the version seem inadequate given the large number of places where the version is referenced, such nf-test snap files and the CHANGELOG.

[edmundmiller]

Hey @birnbera, the --platform=linux/amd64 is on purpose. It's for Apple ARM-based computers. We really should rename that, and maybe it should be apple and arm correctly using the arm containers.

Let's open an issue on tools for it and make sure it's across the board or if we should avoid the name altogether to avoid gotchas.

[birnbera]

@edmundmiller I believe the correct platform name for ARM processors is arm64, not amd64.

[edmundmiller]

@edmundmiller I believe the correct platform name for ARM processors is arm64, not amd64.

You're right! But that's not the purpose of the profile. It's for m1 etc. based processors, not Linux based processors. Here's the PR originally adding the profile.

You shouldn't need to specify that unless you're emulating the processors. See this PR I'm working on for proper ARM support.

I personally find it confusing as we add arm support, but the arm profile doesn't do what users expect. I've made an issue in the tools repo, feel free to weigh in there!