-
Notifications
You must be signed in to change notification settings - Fork 14
Bogatell Patch Release - v.1.1.1 #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bump dev version post release
Update link for readme
Add provenance
Put all plugins in one declaration
Json schema improvements
…ix issues with plugins
Important! Template update for nf-core/tools v3.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some small suggestions
@@ -23,7 +23,22 @@ | |||
"type": "string", | |||
"meta": ["aligner"], | |||
"pattern": "^\\S+$", | |||
"errorMessage": "align name must be provided and cannot contain spaces", | |||
"enum": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should the aligner be provided in capital letters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how they are parsed in the pipeline, just a design choice
fix schema
test patch
Fix seqera platform test
Merge Dev to Master for Bogatell Patch release.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).