Skip to content

Bogatell Patch Release - v.1.1.1 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
May 27, 2025
Merged

Bogatell Patch Release - v.1.1.1 #223

merged 68 commits into from
May 27, 2025

Conversation

luisas
Copy link
Collaborator

@luisas luisas commented May 12, 2025

Merge Dev to Master for Bogatell Patch release.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/multiplesequencealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

luisas and others added 30 commits February 24, 2025 16:24
Put all plugins in one declaration
Important! Template update for nf-core/tools v3.2.1
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some small suggestions

@@ -23,7 +23,22 @@
"type": "string",
"meta": ["aligner"],
"pattern": "^\\S+$",
"errorMessage": "align name must be provided and cannot contain spaces",
"enum": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should the aligner be provided in capital letters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how they are parsed in the pipeline, just a design choice

@luisas luisas changed the title Dev to Master for Bogatell Patch Release Bogatell Patch Release - v.1.1.1 May 27, 2025
@luisas luisas merged commit 79724da into master May 27, 2025
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants