skip arm package failures #8588
Open
+333
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundmiller
force-pushed
the
skip-arm-package-failures
branch
from
e34b9f2 to
88c55d5
Compare
mashehu
reviewed
Jun 2, 2025
edmundmiller
force-pushed
the
skip-arm-package-failures
branch
from
bc4491b to
83a6d7c
Compare
ewels
reviewed
Jun 3, 2025
edmundmiller
force-pushed
the
skip-arm-package-failures
branch
from
2a5983e to
b1e9b57
Compare
- Introduced `filter_arm_failure_tests.py` to filter test paths based on ARM build failure markers. - Added `manage_arm_failures.py` for adding, removing, and listing ARM failure markers for modules. - Created `report_arm_build_failure.py` to filter ARM builds based on failure markers in CI workflows. - Updated GitHub Actions workflows to integrate ARM failure filtering. - Documented ARM build failure management in `ARM_BUILD_FAILURES.md`. - Added example failure marker for `fastqc` module.
- Removed scripts for managing ARM build failures and filtering tests. - Introduced `filter_arm_tests.py` to skip ARM tests based on `.skip-arm` marker files. - Updated GitHub Actions workflows to utilize the new skip marker system. - Revised documentation to reflect changes in ARM test management.
- Changed the path for the `.skip-arm` marker from the module root to the `tests` directory in `filter_arm_tests.py` and GitHub Actions workflows. - Updated documentation in `ARM_BUILD_FAILURES.md` to reflect the new path for skipping ARM tests. - Added a new `.skip-arm` file for the `kraken2` module in the `tests` directory.
- Introduced a step to commit and push ARM skip markers when tests fail on the linux/arm64 platform. - Configured Git user details for the bot to handle commits automatically.
This reverts commit c4c70ca.
edmundmiller
force-pushed
the
skip-arm-package-failures
branch
2 times, most recently
from
7232766 to
a02529f
Compare
- Introduced `add_arm_failure_tag.py` script to append the `arm_failure` tag to nf-test files for modules that fail on ARM architecture. - Updated GitHub workflows to utilize the new script for tagging during ARM test failures. - Removed obsolete `.skip-arm` files in favor of the new tagging system.
edmundmiller
force-pushed
the
skip-arm-package-failures
branch
from
a02529f to
3d8a24e
Compare
mashehu
reviewed
Jun 4, 2025
| @@ -188,7 +187,7 @@ jobs: | |||
| run: exit 1 | |||
|
|
|||
| - name: If no tests run, but filtered_paths was not empty and no tests succeeded, fail | |||
| if: ${{ needs.nf-test.outputs.filtered_paths != '' && !contains(needs.*.result, 'success') }} | |||
| if: ${{ needs.nf-test.outputs.arm_filtered_paths != '' && !contains(needs.*.result, 'success') }} | |||
There was a problem hiding this comment.
where is arm_filtered_paths defined?
mashehu
reviewed
Jun 4, 2025
There was a problem hiding this comment.
no docs in this repo please. this should be on the website.
There was a problem hiding this comment.
also I think this is outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8586
When an ARM build fails in either the conda-wave or dockerfile-wave jobs, it will: