Skip to content

Remove default channels from all remaining modules #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2025

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented May 28, 2025

Includes replacement of (deprecated) KRONADB module with the replacement (does not require any workflow changes)

And a couple of minor version bumps

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/mag main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the nf-core/mag dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@jfy133 jfy133 changed the base branch from main to dev May 28, 2025 15:55
Copy link

github-actions bot commented May 28, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7ab25ce

+| ✅ 335 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  47 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.1
  • Run at 2025-05-29 06:52:37

@jfy133 jfy133 marked this pull request as ready for review May 28, 2025 16:02
Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KRONADB module should be removed, right?

@jfy133
Copy link
Member Author

jfy133 commented May 29, 2025

Good catch @dialvarezs !

Done that now, otherwise looks good?

@jfy133
Copy link
Member Author

jfy133 commented May 29, 2025

@nf-core-bot fix linting

Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Looks good now

@jfy133 jfy133 merged commit abb983a into dev May 29, 2025
16 checks passed
@jfy133 jfy133 deleted the remove-default-channels branch May 29, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants