Skip to content

Use more robust method of database loading for GTDBTK #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Apr 8, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as ready for review April 8, 2025 09:03
@prototaxites
Copy link
Contributor

Is this listFiles() bit necessary now?

gtdb_dir = gtdb.listFiles()

@jfy133
Copy link
Member Author

jfy133 commented Apr 8, 2025

Ha good question... OK I'll test...

Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Jim's question, it looks good for me!

Copy link

github-actions bot commented Apr 9, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cd9dd7e

+| ✅ 334 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗  52 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-04-09 08:59:53

Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133
Copy link
Member Author

jfy133 commented Apr 9, 2025

It workeD!

@jfy133 jfy133 merged commit f14664e into dev Apr 9, 2025
16 checks passed
@jfy133 jfy133 deleted the udpate-gtdbtk branch May 12, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants