-
Notifications
You must be signed in to change notification settings - Fork 23
Release PR for 2.1.0 #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release PR for 2.1.0 #456
Conversation
Post-release version bump
Update citations
Oh and @mashehu, if I specify a more recent minimum Nextflow version in Leave like this or change back?
|
tests are more important than linting in this case: so change |
Apply suggestions from v.2.10 code review
Fix nf-test name
Fix test (config) name
@jasmezz I've fixed the pending checks (something that had to be changed in the repo settings), I bumped the date for tomorrow, and as it was Matthias who said we should use the later minimal version with linting skip, I've done that too (I realised when reading the comment that the minimal CI version doesn't correspond to the minimal version we specify in |
@jasmezz conda is working now but it looks like there are ampcombi snapshot differences in them... |
Fix nf-tests
Fix nf-tests: bakta, prokka
Only one of the download pipeline is not passing but this is an upstream bug with the CI test not the funcitonality itself (the other test passes) |
Edit 1: WE WILL IGNORE CONDA CI TEST FAILURES TO THEM BEING A CONDA OVERLAPPING LOCK ERROR RELATED TO NEXTFLOW
Edit 2: Nevermind, we do care and updated Nextflow to 24.10.4 where the above bug is fixed.
Added
--taxa_classification_mmseqs_compressed
parameter. (by @jasmezz)--annotation_bakta_hmms
. (by @jasmezz)Fixed
rgi/main
module to fix incorrect variable name. (by @amizeranschi and @jasmezz)--annotation_pyrodigal_usespecialstopcharacter
parameter to improve AMPlify screening. (by @jasmezz)ampcombi2/parsetables
. (by @jasmezz)Dependencies
Deprecated
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).