-
Notifications
You must be signed in to change notification settings - Fork 23
Update docs + database params, skip hmmsearch #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, will now load in launch and see how it looks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on local clone and nf-core launch .
and selecting 'webbased'
You have very inconsistent icons, e.g. AMP have screwdriver/wrench icon, except AMPCombi which have two different ones, ARG are all the microbe icon (find), BGC has a mixture of microbes and screwdriver/wrench icon (antiSMASH). Classification is also mixed, whereas annotation is all the same.
I would suggest having one icon per ARG/BGC/AMP category.
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few more changes, but otherwise you can now merge @jasmezz , we will find anything else later but they will be minor 😬
Update docs and database parameters, skip hmmsearch by default (to not have pipeline crash if user doesn't provide HMM files).
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).