Skip to content

Reactivate DeepARG database downloading and tests as server is back up #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

Reactivate DeepARG database downloading and tests as server is back up #237

merged 2 commits into from
Mar 8, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Mar 8, 2023

Reactivate DeepARG, closes #186

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 8, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit df33ef2

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-08 10:02:08

@jfy133 jfy133 linked an issue Mar 8, 2023 that may be closed by this pull request
Reactivate DeepARG in tests once database downloading are possible #186
Closed
@jfy133 jfy133 requested a review from a team March 8, 2023 13:28
jasmezz
jasmezz approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 merged commit ff783fc into dev Mar 8, 2023
@jfy133 jfy133 deleted the reactivate-deeparg branch March 8, 2023 13:46
@jasmezz jasmezz mentioned this pull request Apr 26, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmezz jasmezz jasmezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactivate DeepARG in tests once database downloading are possible
2 participants
@jfy133 @jasmezz