Skip to content

fix: adjust table width for better view #7200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented May 7, 2025

πŸ“ Summary

This fix applies only to the view mode

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
before_ after_

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@AIlkiv AIlkiv requested review from max-nextcloud and mejo- as code owners May 7, 2025 13:33
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the collectives app it's important to have similar layout of edit and view mode, for as less friction as possible when toggling between the two. Therefore I would prefer to keep it as is.

@AIlkiv
Copy link
Contributor Author

AIlkiv commented May 7, 2025

@mejo-
I agree, but on the other hand, when viewing the page, it looks like an incorrect styles.

Perhaps this layout will be a compromise?
demo

@mejo-
Copy link
Member

mejo- commented May 7, 2025

What do our designers think? Cc @marcoambrosini

@marcoambrosini
Copy link
Member

I think ideally we want to make the table full width at all times move this "buttons column" outside. Much like the "+" button and link preview button on the left side.

When the screen is smaller and these don't fit, I don't mind the horizontal jump when switching modes. What's more unsettling are vertical jumps. But in this case, either way is fine from my pov.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants