Skip to content

feat: Add experimental option to allow typing during connectivity issues or being offline #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 6, 2025

Something to have merged so we can experiment on daily

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.28%. Comparing base (84ee761) to head (a319d90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6933   +/-   ##
=======================================
  Coverage   52.27%   52.28%           
=======================================
  Files         479      479           
  Lines       41736    41742    +6     
  Branches     1024     1024           
=======================================
+ Hits        21819    21825    +6     
  Misses      19815    19815           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliusknorr juliusknorr marked this pull request as ready for review March 11, 2025 08:31
@juliusknorr
Copy link
Member Author

Should be good to go to main actually :)

@juliusknorr juliusknorr requested a review from a team March 11, 2025 08:35
@juliusknorr juliusknorr force-pushed the feat/experiment-offline-typing branch from 3c6fe90 to 0022e49 Compare March 23, 2025 10:59
@juliusknorr juliusknorr force-pushed the feat/experiment-offline-typing branch from 0022e49 to 343bd85 Compare April 3, 2025 06:11
@juliusknorr juliusknorr requested a review from elzody April 9, 2025 07:51
@juliusknorr juliusknorr force-pushed the feat/experiment-offline-typing branch from 343bd85 to 0182052 Compare April 11, 2025 10:38
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Apr 11, 2025

@juliusknorr I think you will also want to check for the flag in this watcher:

requireReconnect(val) {
if (val) {
this.emit('sync-service:error')
}
if (this.$editor?.isEditable === val) {
this.$editor.setEditable(!val)
}
},

@juliusknorr juliusknorr force-pushed the feat/experiment-offline-typing branch from 0182052 to 74fd252 Compare April 15, 2025 18:42
@juliusknorr juliusknorr force-pushed the feat/experiment-offline-typing branch from 74fd252 to a319d90 Compare May 8, 2025 12:05
@juliusknorr
Copy link
Member Author

@max-nextcloud I adjusted that. Do you think it makes sense to have that given that you focus more on this the next time? Or do you want to approach this differently? Could it still be useful for testing?

I'd be fine to either merge or close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants