-
Notifications
You must be signed in to change notification settings - Fork 96
feat: Add experimental option to allow typing during connectivity issues or being offline #6933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6933 +/- ##
=======================================
Coverage 52.27% 52.28%
=======================================
Files 479 479
Lines 41736 41742 +6
Branches 1024 1024
=======================================
+ Hits 21819 21825 +6
Misses 19815 19815
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Should be good to go to main actually :) |
3c6fe90
to
0022e49
Compare
0022e49
to
343bd85
Compare
343bd85
to
0182052
Compare
@juliusknorr I think you will also want to check for the flag in this watcher: text/src/components/Editor.vue Lines 360 to 367 in 0182052
|
0182052
to
74fd252
Compare
…ues or being offline Signed-off-by: Julius Knorr <[email protected]>
74fd252
to
a319d90
Compare
@max-nextcloud I adjusted that. Do you think it makes sense to have that given that you focus more on this the next time? Or do you want to approach this differently? Could it still be useful for testing? I'd be fine to either merge or close |
Something to have merged so we can experiment on daily
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)