Skip to content

Enhancement: Update rows via import #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enhancement: Update rows via import #1824

wants to merge 3 commits into from

Conversation

Koc
Copy link
Contributor

@Koc Koc commented May 27, 2025 •
edited
Loading

This PR adds possibility to update rows via import. Closes #1403

🗒️ TODO

  • Automatically select "ID (Meta)" column
  • Add new tests

🎥 Preview

nextcloud-tables-2025-05-28_00.13.09.mp4

@Koc Koc requested review from enjeck and blizzz as code owners May 27, 2025 14:49
@Koc Koc force-pushed the feature/allow-update-rows-via-import branch 3 times, most recently from 7d9820e to 35c3a82 Compare May 27, 2025 22:11
@blizzz blizzz added enhancement New feature or request 2. developing Work in progress labels Jun 11, 2025
AIlkiv
AIlkiv requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@AIlkiv AIlkiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. I have a few comments

@Koc Koc force-pushed the feature/allow-update-rows-via-import branch 13 times, most recently from 7cbff61 to 82651fc Compare July 8, 2025 23:52
@Koc Koc force-pushed the feature/allow-update-rows-via-import branch from 82651fc to 9ebf499 Compare July 8, 2025 23:59
@Koc
Copy link
Contributor Author

Koc commented Jul 9, 2025 •
edited
Loading

Any ideas why new scenario not pass for NC 29?

    Given file "update-rows.csv" exists for user "participant1" with the following data    # FeatureContext::createCsvFile()
      | ID      | one         | two |
      | {rowId} | AHA updated | 99  |
      |         | new row     | 100 |
      Failed asserting that 401 matches expected 201.

at the same time it works fine for all other versions. I've inspired from already existent Given user :user uploads file :file which works on NC29 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AIlkiv AIlkiv AIlkiv requested changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export/import data duplicate row instead of updating it (even with "ID" column left untouched)
3 participants
@Koc @AIlkiv @blizzz