Skip to content

replace deprecated getQueryPart() in ContextMapper #1740

Open
@blizzz

Description

@blizzz
  • Doctrine 4 removed getQueryPart() (PR)
  • … and marked it as deprecated in 3.8 (PR)
  • So it is also marked as deprecated in NCs abstraction (PR) as of NC 30

Money quote:

This function is going to be removed with the next Doctrine/DBAL update and we can not fix this in our wrapper. Please track the details you need, outside the object.

We use it in one place to figure out whether a WHERE condition is already set to know whether we either have to use where() or andWhere() in that method. Cf.

if ($qb->getQueryPart('where') === null) {
$qb->where($whereExpression);
} else {
$qb->andWhere($whereExpression);
}

Server wants to bump to Doctrine 4 in the upcoming version.

  • Figure out whether we can solve it with available methods
  • If so, implement the changes in a backwards compatible manner
  • If not so, bring up necessary changes to the IQueryBuilder abstraction in server and follow up

Side effect: currently there is potential deprecation log spam against >= NC 30.

Metadata

Metadata

Assignees

No one assigned

    Labels

    1. to developAccepted and waiting to be taken care oftechnical debtTechnical issue

    Type

    Projects

    Status

    📄 To do (~10 entries)

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions