-
Notifications
You must be signed in to change notification settings - Fork 104
feat(date): allow restrictions for dates and query date ranges #2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
============================================
+ Coverage 43.31% 43.55% +0.24%
- Complexity 888 906 +18
============================================
Files 78 78
Lines 3371 3389 +18
============================================
+ Hits 1460 1476 +16
- Misses 1911 1913 +2 🚀 New features to boost your workflow:
|
c610911
to
2fb862b
Compare
88a2440
to
231b87a
Compare
231b87a
to
db7bee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! :) Added some wording suggestions to make it a bit more easy to understand / less technical.
And I’d say the icons can be removed as they are the same and thus mostly visual noise? It’s a sub-item of the checkbox anyway so it’s fine to not have an icon and thus look a bit indented.
@jancborchardt thanks for the review :)
No, they are separate from the checkbox and always shown. The restrictions of which date can be chosen apply also to single date questions. That's why I added the icons. Without them it felt wrong to me. |
7b55891
to
b2310a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As icons, how about:
- "Today" for Earliest date
- "Event" for Latest date
b2310a2
to
69b267a
Compare
I've changed the icons and updated the screenshot in the OP :) |
69b267a
to
b639d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chartman123 sorry, for some reason the icon link didn’t save the "fill" attribute. :\ The icons should use the filled versions, as we always do.
This adds the possibility to add restrictions to the selectable date and to ask for a date range Signed-off-by: Christian Hartmann <[email protected]>
b639d33
to
53835cd
Compare
@jancborchardt fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is simpler than 4 date types.
This is awesome, thanks a ton! 🎊 |
This closes #2396 by allowing to set minimum and maximum dates and to query date ranges
Set question settings for minimum/maximum dates and if the user must enter a date range:

Restricted dates and date range picker in submit view:

Results in summary / responses view:


Signed-off-by: Christian Hartmann [email protected]