-
Notifications
You must be signed in to change notification settings - Fork 780
talk - fix eternal relay-ip #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Simon L <[email protected]>
IPv4_ADDRESS_TALK="$(dig nextcloud-aio-talk IN A +short | grep '^[0-9.]\+$' | sort | head -n1)" | ||
IPv6_ADDRESS_TALK="$(dig nextcloud-aio-talk AAAA +short | grep '^[0-9a-f:]\+$' | sort | head -n1)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these two always the container IP addresses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. In that case, I propose additional changes in the upcoming comment.
Follow up (#3217 (comment)) I now understand your setup better, it wasn't totally clear for me. As you relay internally between eturnal and your talk component, you do not need a publicly facing IP address as a relay address. I run a similar setup in a kubernetes setup ;) Therefore, I suggest to eliminate the STUN lookup as well from your Dockerfile, use the 2nd option from here #2855 (comment) The STUN query would return an external IP address, which will let your setup fail I guess in 99,99% of the cases, because your container is not reachable publicly on the relay port range P.S. And you can leave away the |
Signed-off-by: Simon L <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side it looks good, but let's wait what @sando38 says
Thank you both! :) |
Follow-up to #2855
cc @sando38