nextcloud - improve healthcheck #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
3. to review
41 tasks
|
@frederikb96 does this look good to you? :) |
Look's nice, thanks a lot for such a fast reply and fix :) |
Zoey2936
requested changes
Aug 18, 2023
There was a problem hiding this comment.
I would instead change the start-period https://docs.docker.com/engine/reference/builder/#healthcheck
Good idea, thanks! |
Signed-off-by: Simon L <[email protected]> Revert "nextcloud - improve healthcheck" This reverts commit d9352c3. Update Dockerfile
szaimen
force-pushed
the
enh/3197/improve-nextcloud
branch
from
d9352c3 to
774d109
Compare
Zoey2936
approved these changes
Aug 18, 2023
|
Hm... I wonder how to fix the docker Lint workflow... |
|
Seems like we need another patch: https://github.com/replicatedhq/dockerfilelint/pull/167/files |
szaimen
force-pushed
the
enh/3197/improve-nextcloud
branch
from
0f6383f to
1db5f7c
Compare
Signed-off-by: Simon L <[email protected]>
szaimen
force-pushed
the
enh/3197/improve-nextcloud
branch
from
1db5f7c to
6f51795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close part of #3197