Skip to content

fix: Muting rule inter condition operator ambiguous #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

BPDanek
Copy link
Contributor

@BPDanek BPDanek commented Jan 23, 2023

Description

Please include a summary of the change and which issue is fixed (if relevant).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ BPDanek
✅ mbazhlekova
❌ bdanek-ert
You have signed the CLA already but the status is still pending? Let us recheck it.

@NSSPKrishna
Copy link
Member

Hi @BPDanek, thank you for your contribution. Can you please sign the CLA so that we could go ahead and review this PR?

@BPDanek
Copy link
Contributor Author

BPDanek commented Jan 27, 2023

I have it signed; just hit "recheck"

@codecov-commenter
Copy link

Codecov Report

Merging #2219 (839d135) into main (fabce46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files          85       85           
  Lines       20164    20165    +1     
=======================================
+ Hits         7235     7236    +1     
  Misses      12791    12791           
  Partials      138      138           
Impacted Files Coverage Δ
newrelic/resource_newrelic_alert_muting_rule.go 48.22% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mbazhlekova
Copy link
Contributor

Hi @BPDanek thank you for your contribution! One thing, can you run go fmt on resource_newrelic_alert_muting_rule.go? Looks like the formatting is a little off.

@mbazhlekova mbazhlekova merged commit 4e77c35 into newrelic:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants