Windows update helm chart #1176

TmNguyen12 · 2025-03-07T01:39:12Z

Description

Adds daemonset_windows.yaml to the chart templates
Removed linux specific securityContexts
Added windowsNodeSelector param
Added securityContext.windowsOptions defaults
Update and add helm unit tests
do not merge until ready for public preview

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)
New feature / enhancement (non-breaking change which adds functionality)
Security fix
Bug fix (non-breaking change which fixes an issue)

Checklist:

Add changelog entry following the contributing guide
Documentation has been updated
This change requires changes in testing:
- unit tests
- E2E tests

charts/newrelic-infrastructure/values.yaml

dbudziwojskiNR · 2025-03-13T17:12:36Z

CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

 ### 🚀 Enhancements
 - Add options for Windows server 2019 and Windows server 2022 deployments in E2E-resources @TmNguyen12 [#1149](https://github.com/newrelic/nri-kubernetes/pull/1149)
-
+- Add Windows Helm templates and unit tests for kubelet support @TmNguyen12 [#1176] (https://github.com/newrelic/nri-kubernetes/pull/1176)


Suggested change

- Add Windows Helm templates and unit tests for kubelet support @TmNguyen12 [#1176] (https://github.com/newrelic/nri-kubernetes/pull/1176)

- Add Windows Helm templates and unit tests for kubelet support @TmNguyen12 [#1176](https://github.com/newrelic/nri-kubernetes/pull/1176)

dbudziwojskiNR · 2025-03-13T17:13:58Z

charts/newrelic-infrastructure/README.md

@@ -192,6 +193,20 @@ integrations that you have configured.
 | tolerations | list | `[]` | Sets pod's tolerations to node taints almost globally. (See [Affinities and tolerations](README.md#affinities-and-tolerations)) |
 | updateStrategy | object | See `values.yaml` | Update strategy for the deployed DaemonSets. |
 | verboseLog | bool | `false` | Sets the debug logs to this integration or all integrations if it is set globally. Can be configured also with `global.verboseLog` |
+| windowsNodeSelector | object |  `{ kubernetes.io/os: windows, node.kubernetes.io/windows-build: BUILD_NUMBER }` | Sets windows pod's selector. Refer to [Windows support](#tbd) |
+| windowsOsList.agentImage | string | `""` | Overrides the infrastructure-agent windows image |


Are we not able to auto-detect the image we want? We seem to already be using taints on a windows-flavoured deployment/daemonset.

We can. This option is if people wanted to override the auto-selected images (like I am for development purposes)

dbudziwojskiNR · 2025-03-13T17:14:59Z

charts/newrelic-infrastructure/templates/kubelet/daemonset-windows.yaml

+      {{- end }}
+      nodeSelector:
+        {{- if $.Values.kubelet.windowsNodeSelector }}
+{{ toYaml $.Values.kubelet.windowsNodeSelector | indent 8 }}


Suggested change

{{ toYaml $.Values.kubelet.windowsNodeSelector | indent 8 }}

{{- toYaml $.Values.kubelet.windowsNodeSelector | indent 8 }}

dbudziwojskiNR · 2025-03-13T17:17:16Z

Are we planning on remove the enableWindows flag in the future? Or is this flag intended to be in the agent.

TmNguyen12 · 2025-03-27T19:24:53Z

Are we planning on remove the enableWindows flag in the future? Or is this flag intended to be in the agent.

Was intended to be part of the agent, but open to discuss if you have concerns

dbudziwojskiNR · 2025-03-27T23:56:21Z

CHANGELOG.md


 ### ⛓️ Dependencies
 - Updated github.com/spf13/viper to v1.20.0 - [Changelog 🔗](https://github.com/spf13/viper/releases/tag/v1.20.0)
 - Updated go to v1.24.1
 - Updated golang.org/x/crypto to v0.36.0
 - Updated github.com/google/go-cmp to v0.7.0 - [Changelog 🔗](https://github.com/google/go-cmp/releases/tag/v0.7.0)

-## v3.36.0 - 2025-03-24


So we can't change releases that have already been cut. You'll need to stick to adding any new changes in the unreleased section. Details here

dbudziwojskiNR · 2025-03-27T23:58:18Z

charts/internal/e2e-resources/templates/windows-deployment.yaml

@@ -2,7 +2,7 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: windows-server-2019
+  name: {{ .Release.Name }}-windows-server-2019


Appending to a variable sized string could cause installation failure if the total size exceeds DNS limits. You'll need to use several helper methods from the common library to do this safely. Example here: usage and helper

dbudziwojskiNR · 2025-03-27T23:58:59Z

charts/internal/e2e-resources/templates/windows-deployment.yaml

@@ -2,7 +2,7 @@
 apiVersion: apps/v1


Could we remove this .Values.windows.is2019 config since we're using this node selector: node.kubernetes.io/windows-build: 10.0.17763?

In that scenario, e2e-resources when installed will always have 2 windows pods stuck in "Pending" because they're looking for a node.

dbudziwojskiNR · 2025-03-27T23:59:45Z

charts/internal/e2e-resources/templates/windows-deployment.yaml

@@ -47,7 +51,7 @@ spec:
 apiVersion: apps/v1


Same thing here for Windows 2022

dbudziwojskiNR · 2025-03-28T00:00:35Z

charts/newrelic-infrastructure/README.md

@@ -136,6 +136,7 @@ integrations that you have configured.
 | customSecretName | string | `""` | In case you don't want to have the license key in you values, this allows you to point to a user created secret to get the key from there. Can be configured also with `global.customSecretName` |
 | dnsConfig | object | `{}` | Sets pod's dnsConfig. Can be configured also with `global.dnsConfig` |
 | enableProcessMetrics | bool | `false` | Collect detailed metrics from processes running in the host. This defaults to true for accounts created before July 20, 2020. ref: https://docs.newrelic.com/docs/release-notes/infrastructure-release-notes/infrastructure-agent-release-notes/new-relic-infrastructure-agent-1120 |
+| enableWindows | bool | `false` | Enables collection of metrics from Windows containers. Refer to the [Windows support](#tbd) section for more details. |


Could we have this link to a GH README while we wait for docs on NR? That way folks don't think it's a broken link.

dbudziwojskiNR · 2025-03-28T00:02:49Z

charts/newrelic-infrastructure/templates/_helpers.tpl

@@ -116,3 +116,12 @@ readOnlyRootFilesystem: true

 {{- toYaml $finalSecurityContext -}}
 {{- end -}}
+
+{{- define "windowsIntegrationImage" -}}


Is this the infrastructure image? If so, we may want to call it windowsInfrastructureImage to be clear

We also may want to use namespacing of these helpers: nriKubernetes. windowsInfrastructureImage

dbudziwojskiNR · 2025-03-28T00:09:17Z

charts/newrelic-infrastructure/templates/podsecuritypolicy.yaml

@@ -4,8 +4,10 @@ kind: PodSecurityPolicy
 metadata:
  name: privileged-{{ include "newrelic.common.naming.fullname" . }}
 spec:
+{{- if not .Values.enableWindows }}


Is there a change to the linux experience if this is off? Enabling windows shouldn't cause a regression on the linux experience, if it does, we should create a new security policy just for Windows.

TmNguyen12 added 2 commits March 6, 2025 17:17

windows helm templates working when installed directly from this repo

666e7a3

update chart readme

1658e7a

TmNguyen12 requested a review from a team as a code owner March 7, 2025 01:39

TmNguyen12 added 2 commits March 6, 2025 17:56

updated readme and values.yaml comments

1851cdc

j

947d71b

kondracek-nr reviewed Mar 10, 2025

View reviewed changes

charts/newrelic-infrastructure/values.yaml Outdated Show resolved Hide resolved

TmNguyen12 added 3 commits March 12, 2025 10:41

update context switching and securityContexts for windows

9afffb5

add helm unit tests for windows-daemonset template

5ac01e8

fix spacing in values

b44541f

TmNguyen12 requested a review from kondracek-nr March 13, 2025 17:00

dbudziwojskiNR requested changes Mar 13, 2025

View reviewed changes

updates to e2e-resources and fix spacing

375caba

TmNguyen12 requested a review from dbudziwojskiNR March 27, 2025 17:00

Merge branch 'main' into windowsUpdateHelmChart

245e073

TmNguyen12 changed the title ~~WIP: Windows update helm chart~~ Windows update helm chart Mar 27, 2025

TmNguyen12 added 5 commits March 27, 2025 12:51

revert interval helm tests

da33f5c

fix daemonset-windows test

682cb94

go mod tidy and update readme

95e0131

update affinity default tests and wording

27e5b8a

test fix kubelet

087bea9

dbudziwojskiNR requested changes Mar 28, 2025

View reviewed changes

TmNguyen12 added 5 commits April 1, 2025 09:20

add helper functions for DNSnaming, add windows.md

e4d1f4d

spacing and nindent

c74e4bd

re-add conditional for e2e-windows-deployment

27000ab

Merge branch 'main' into windowsUpdateHelmChart

6ac8f5a

add more securityContext helm unit tests

59565e7

TmNguyen12 requested a review from dbudziwojskiNR April 1, 2025 17:11

remove hostnetwork from windows container - unsupported

ed38405

TmNguyen12 added 3 commits April 3, 2025 09:16

remove unnecessary hostnetwork windows tests

cd9aee2

Merge branch 'main' into windowsUpdateHelmChart

198c463

fix appropriate changelog header

73cce96

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows update helm chart #1176

Windows update helm chart #1176

TmNguyen12 commented Mar 7, 2025 •

edited

Loading

dbudziwojskiNR Mar 13, 2025

dbudziwojskiNR Mar 13, 2025

TmNguyen12 Mar 13, 2025

dbudziwojskiNR Mar 13, 2025

dbudziwojskiNR commented Mar 13, 2025

TmNguyen12 commented Mar 27, 2025

dbudziwojskiNR Mar 27, 2025

dbudziwojskiNR Mar 27, 2025

dbudziwojskiNR Mar 27, 2025

TmNguyen12 Mar 28, 2025

dbudziwojskiNR Mar 27, 2025

dbudziwojskiNR Mar 28, 2025

dbudziwojskiNR Mar 28, 2025

dbudziwojskiNR Mar 28, 2025

dbudziwojskiNR Mar 28, 2025

	- Add Windows Helm templates and unit tests for kubelet support @TmNguyen12 [#1176] (https://github.com/newrelic/nri-kubernetes/pull/1176)
	- Add Windows Helm templates and unit tests for kubelet support @TmNguyen12 [#1176](https://github.com/newrelic/nri-kubernetes/pull/1176)

	{{ toYaml $.Values.kubelet.windowsNodeSelector \| indent 8 }}
	{{- toYaml $.Values.kubelet.windowsNodeSelector \| indent 8 }}

Windows update helm chart #1176

Are you sure you want to change the base?

Windows update helm chart #1176

Conversation

TmNguyen12 commented Mar 7, 2025 • edited Loading

Description

Type of change

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbudziwojskiNR commented Mar 13, 2025

TmNguyen12 commented Mar 27, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TmNguyen12 commented Mar 7, 2025 •

edited

Loading