feat: Added support for knex #3172
Conversation
|
|
||
| registerInstrumentations({ | ||
| instrumentations: [ | ||
| new KnexInstrumentation({ maxQueryLength: -1, requireParentSpan: true }) |
There was a problem hiding this comment.
this instrumentation will conflict with our agent depending on the underlying db engine. I found during our initial POC that if you rely on db engines that we instrument you get duplicate segments. This needs to be solved before this is merged
| removeModules(['knex', 'better-sqlite3']) | ||
| }) | ||
|
|
||
| test('records queries', (t, end) => { |
There was a problem hiding this comment.
if we're writing versioned tests they should align with other db libraries we instrument to ensure parity. you can check mysql, pg, etc for reference
There was a problem hiding this comment.
I believe this has been addressed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
==========================================
- Coverage 97.63% 97.59% -0.05%
==========================================
Files 339 340 +1
Lines 51023 51049 +26
==========================================
+ Hits 49818 49822 +4
- Misses 1205 1227 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds support for
knexas the initial implementation of automatic OTEL bridge configuration.