Skip to content

Add Gemini text generations instrumentation #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 15, 2025

Conversation

umaannamalai
Copy link
Contributor

This PR adds instrumentation and tests for Gemini text generations

@umaannamalai umaannamalai changed the base branch from feature-gemini-instrumentation to main April 8, 2025 04:50
@umaannamalai umaannamalai changed the base branch from main to feature-gemini-instrumentation April 8, 2025 04:50
Copy link

github-actions bot commented Apr 8, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 4 0 0 0.47s
✅ MARKDOWN markdownlint 7 0 0 0 0.94s
✅ MARKDOWN markdown-link-check 7 0 0 17.06s
✅ PYTHON ruff 900 0 0 0 0.57s
✅ PYTHON ruff-format 900 0 0 0 0.21s
✅ YAML prettier 10 0 0 0 0.95s
✅ YAML v8r 10 0 0 5.25s
✅ YAML yamllint 10 0 0 0.55s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@umaannamalai umaannamalai marked this pull request as ready for review April 8, 2025 20:48
@umaannamalai umaannamalai requested a review from a team as a code owner April 8, 2025 20:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 76.72956% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-gemini-instrumentation@4f9d3e6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
newrelic/hooks/mlmodel_gemini.py 76.72% 28 Missing and 9 partials ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             feature-gemini-instrumentation    #1349   +/-   ##
=================================================================
  Coverage                                  ?   81.45%           
=================================================================
  Files                                     ?      205           
  Lines                                     ?    23088           
  Branches                                  ?     3650           
=================================================================
  Hits                                      ?    18807           
  Misses                                    ?     3055           
  Partials                                  ?     1226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the tests-failing label Apr 8, 2025
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting a partial review-I'll review the rest tomorrow.

Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to check the code coverage report to make sure we covered all the cases but it seems it's not available. Maybe it will be after you push some changes or maybe just take a look at it locally and double check after.

@mergify mergify bot removed the tests-failing label Apr 14, 2025
@hmstepanek hmstepanek merged commit 6f9af94 into feature-gemini-instrumentation Apr 15, 2025
52 checks passed
@hmstepanek hmstepanek deleted the gemini-text-generations branch April 15, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants