Skip to content

Async Elasticsearch #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Async Elasticsearch #1348

wants to merge 6 commits into from

Conversation

TimPansino
Copy link
Contributor

Overview

Copy link

github-actions bot commented Apr 7, 2025

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 5 0 0 0.49s
✅ MARKDOWN markdownlint 7 0 0 0 1.02s
✅ MARKDOWN markdown-link-check 7 0 0 14.76s
❌ PYTHON ruff 901 1 1 0 0.56s
✅ PYTHON ruff-format 901 2 0 0 0.32s
✅ YAML prettier 11 0 0 0 1.22s
✅ YAML v8r 11 0 0 5.66s
✅ YAML yamllint 11 0 0 0.53s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing label Apr 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 10.37037% with 121 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (d6a1b5d) to head (4544edf).

Files with missing lines Patch % Lines
newrelic/hooks/datastore_elasticsearch.py 0.00% 121 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   81.07%   80.02%   -1.06%     
==========================================
  Files         204      204              
  Lines       22830    22965     +135     
  Branches     3618     3638      +20     
==========================================
- Hits        18509    18377     -132     
- Misses       3121     3396     +275     
+ Partials     1200     1192       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimPansino
Copy link
Contributor Author

Having trouble with aiohttp throwing weird errors around the timeout context manager, but the instance info issues are solved. Going to clean out unnecessary code before I push that up, and then try to fix the errors. I'll be back to this next week.

@TimPansino TimPansino force-pushed the async-elasticsearch branch from 734bf7a to 4544edf Compare April 21, 2025 16:08
@TimPansino TimPansino closed this Apr 21, 2025
@TimPansino TimPansino deleted the async-elasticsearch branch April 21, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants