[NR-55782] Release chart with release toolkit #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paologallinaharbur
changed the title
paologallinaharbur
changed the title
kilokang
reviewed
Oct 10, 2022
There was a problem hiding this comment.
We will need to do a way harder pipeline to avoid having a circular dependency, properly test that we need a new version, and tag the commit that is really meant to be tagged.
But as the first iteration, it is to find these issues. I really like how it looks.
There was a problem hiding this comment.
Looks good to me, I think we can give it a try. Could you write a short document like this for anyone that wants to release the chart can follow ?
paologallinaharbur
force-pushed
the
feat/chartRelease
branch
from
97c2885 to
855860b
Compare
marcsanmi
reviewed
Oct 11, 2022
marcsanmi
reviewed
Oct 11, 2022
paologallinaharbur
force-pushed
the
feat/chartRelease
branch
from
14cfeeb to
a0a792e
Compare
marcsanmi
approved these changes
Oct 13, 2022
paologallinaharbur
force-pushed
the
feat/chartRelease
branch
from
a0a792e to
06d68ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR we will have a new process to release the chart:
As soon as well feel comfortable (even now if we want), we can automatize this easily by adding the
scheduleclause in the triggers.The pipeline has been tested here, few releases were created already in the fork from the changelog and dependabot.
My only concern with the approach is if it was easier so install
rtand run the make, instead of having the logic twice being unable to test the code locally