Skip to content

feat(agent): remove support for PHPs 7.0 and 7.1 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

bduranleau-nr
Copy link
Contributor

@bduranleau-nr bduranleau-nr commented May 29, 2024

EOL PHP 7.0 & 7.1 Support.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 29, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 55/56 passing

@zsistla
Copy link
Contributor

zsistla commented May 29, 2024

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (c1a48d0) to head (e896291).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #907      +/-   ##
==========================================
- Coverage   78.56%   78.16%   -0.41%     
==========================================
  Files         193      193              
  Lines       27293    26802     -491     
==========================================
- Hits        21444    20950     -494     
- Misses       5849     5852       +3     
Flag Coverage Δ
agent-for-php-7.0 ?
agent-for-php-7.1 ?
agent-for-php-7.2 78.16% <ø> (ø)
agent-for-php-7.3 78.18% <ø> (ø)
agent-for-php-7.4 77.89% <ø> (ø)
agent-for-php-8.0 77.91% <ø> (ø)
agent-for-php-8.1 77.90% <ø> (ø)
agent-for-php-8.2 77.49% <ø> (ø)
agent-for-php-8.3 77.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou added the on hold This issue or pull request is necessary, but better suited for the future label Jun 10, 2024
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPs 7.0 and 7.1 need to be deprecated before being EOLed.

@lavarou lavarou force-pushed the chore/eol-php7.0-7.1 branch from 81d2e14 to 0f5254c Compare June 10, 2024 23:10
@lavarou lavarou changed the base branch from dev to feat/deprecate-7.0-and-7.1 June 10, 2024 23:17
@lavarou lavarou changed the title chore(eol): remove PHP 7.0/7.1 from pipeline feat(agent): remove support for PHPs 7.0 and 7.1 Jun 21, 2024
@lavarou lavarou added ready for review and removed on hold This issue or pull request is necessary, but better suited for the future labels Jun 26, 2024
@lavarou lavarou added this to the next-release milestone Jun 26, 2024
@lavarou lavarou changed the base branch from feat/deprecate-7.0-and-7.1 to dev June 26, 2024 21:38
@bduranleau-nr bduranleau-nr force-pushed the chore/eol-php7.0-7.1 branch from 0f5254c to e896291 Compare June 27, 2024 17:53
@bduranleau-nr bduranleau-nr merged commit 8fd1602 into dev Jul 19, 2024
56 checks passed
@bduranleau-nr bduranleau-nr deleted the chore/eol-php7.0-7.1 branch December 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants