Skip to content

feat(agent): add function to convert ini to env #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2024

Conversation

bduranleau-nr
Copy link
Contributor

No description provided.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented May 8, 2024

Test Suite Status Result
Multiverse 9/9 passing
SOAK 55/56 passing

@bduranleau-nr bduranleau-nr marked this pull request as draft May 8, 2024 19:04
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.81%. Comparing base (f000c13) to head (c008006).

Files Patch % Lines
axiom/util_strings.c 77.77% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/env-configuration     #892      +/-   ##
==========================================================
+ Coverage                   78.79%   78.81%   +0.02%     
==========================================================
  Files                         193      193              
  Lines                       27214    27254      +40     
==========================================================
+ Hits                        21443    21481      +38     
- Misses                       5771     5773       +2     
Flag Coverage Δ
agent-for-php-7.0 77.55% <94.44%> (+0.02%) ⬆️
agent-for-php-7.1 77.30% <94.44%> (+0.02%) ⬆️
agent-for-php-7.2 78.23% <94.44%> (+0.02%) ⬆️
agent-for-php-7.3 78.25% <94.44%> (+0.02%) ⬆️
agent-for-php-7.4 77.95% <94.44%> (+0.02%) ⬆️
agent-for-php-8.0 78.02% <94.44%> (+0.02%) ⬆️
agent-for-php-8.1 78.00% <94.44%> (+0.02%) ⬆️
agent-for-php-8.2 77.60% <94.44%> (+0.02%) ⬆️
agent-for-php-8.3 77.60% <94.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr marked this pull request as ready for review May 20, 2024 17:40
@bduranleau-nr bduranleau-nr force-pushed the feat/env-config-parser branch from d58b00e to c008006 Compare May 21, 2024 18:23
@bduranleau-nr bduranleau-nr changed the base branch from feat/env-configuration to dev May 21, 2024 18:27
@bduranleau-nr bduranleau-nr changed the base branch from dev to feat/env-configuration May 21, 2024 18:28
@bduranleau-nr bduranleau-nr merged commit 787c147 into feat/env-configuration May 21, 2024
59 checks passed
@bduranleau-nr bduranleau-nr deleted the feat/env-config-parser branch May 21, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants