Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for NR Control [wip] #1043

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from

Conversation

bduranleau-nr
Copy link
Contributor

@bduranleau-nr bduranleau-nr commented Apr 2, 2025

  • Agent configuration
  • Agent health file generation
  • UUID generation
  • Agent unit tests <-- in progress
  • Agent health update logic
  • Agent <-> Daemon communication
  • Daemon health file management
  • Daemon health update logic
  • Daemon unit tests

@bduranleau-nr bduranleau-nr changed the title feat: add support for NR Control feat: add support for NR Control [wip] Apr 2, 2025
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 2, 2025

Test Suite Status Result
Multiverse 6/8 passing
SOAK 79/79 passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 80.88235% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (8124792) to head (2114de5).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
axiom/util_health.c 83.14% 15 Missing ⚠️
agent/php_nrini.c 75.86% 7 Missing ⚠️
agent/php_minit.c 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1043      +/-   ##
==========================================
- Coverage   77.87%   77.23%   -0.64%     
==========================================
  Files         198      200       +2     
  Lines       27899    28035     +136     
==========================================
- Hits        21727    21654      -73     
- Misses       6172     6381     +209     
Flag Coverage Δ
agent-for-php-7.2 77.46% <80.88%> (-0.68%) ⬇️
agent-for-php-7.3 77.48% <80.88%> (-0.68%) ⬇️
agent-for-php-7.4 77.20% <80.88%> (-0.67%) ⬇️
agent-for-php-8.0 76.59% <80.88%> (-0.66%) ⬇️
agent-for-php-8.1 76.99% <80.88%> (-0.66%) ⬇️
agent-for-php-8.2 76.60% <80.88%> (-0.66%) ⬇️
agent-for-php-8.3 76.60% <80.88%> (-0.66%) ⬇️
agent-for-php-8.4 76.62% <80.88%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants