Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed gaps in Micronaut Http instrumentation #2298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dhilpipre
Copy link
Contributor

Found gaps in instrumentation for Micronaut Http

  • Fixed missing / in MicronautSubresourceInstrumentation.java where the path was missing to separate the pieces of the path
  • Added additional code to methods to name the transaction to give a more meaningful transaction name instead of the default NettyDispatcher

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@jtduffy jtduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a bit of a nit, but can the indents be changed to 4 spaces so it matches the rest of the code? Other than that looks good.

@dhilpipre
Copy link
Contributor Author

Tabs have been changed to spaces as requested

@kmudduluru kmudduluru moved this from Triage to Needs Review in Java Engineering Board Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants