Skip to content

test: Migrate legacy MongoDB tests to ConsoleMF. #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 27, 2025

Conversation

jaffinito
Copy link
Member

Description

  • Removes the web app, fixture, and tests for legacy MongoDB (mongocsharpdriver 1.10.0)
  • Replaces them with a new exerciser in the ConsoleMF app
  • Makes same calls, but has one Fact and looks for more metrics
  • Uses a random DB and removes it when the test completes.
  • Replaces the modern MongoDB package for the net462 TFM with the legacy package
  • Updates modern tests, fixtures, and exerciser to exclude net462

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito requested a review from a team as a code owner March 25, 2025 21:54
@jaffinito jaffinito changed the title test: Migrate legacy MongoDB tests to ConsolfMF. test: Migrate legacy MongoDB tests to ConsoleMF. Mar 26, 2025
tippmar-nr
tippmar-nr previously approved these changes Mar 26, 2025
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finally getting this taken care of!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (ae1a436) to head (9069674).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3055      +/-   ##
==========================================
- Coverage   82.21%   82.18%   -0.04%     
==========================================
  Files         477      477              
  Lines       30623    30623              
  Branches     3426     3426              
==========================================
- Hits        25177    25166      -11     
- Misses       4645     4658      +13     
+ Partials      801      799       -2     
Flag Coverage Δ
Agent 83.23% <ø> (-0.04%) ⬇️
Profiler 72.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jaffinito jaffinito merged commit 2fad2b2 into main Mar 27, 2025
92 checks passed
@jaffinito jaffinito deleted the other/migrate-legacy-mongodb-consolemf branch March 27, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants