test: Upgrade to XUnit 2.9.0, fix some test failures #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrcventura
reviewed
Aug 8, 2024
nrcventura
reviewed
Aug 8, 2024
tests/Agent/IntegrationTests/IntegrationTestHelpers/AgentLogBase.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2686 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 459 459
Lines 29070 29070
Branches 3191 3191
=======================================
Hits 23469 23469
Misses 4811 4811
Partials 790 790
Flags with carried forward coverage won't be shown. Click here to find out more. |
nrcventura
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
AgentLogBase.GetReportingAppLink()to useTryGetLogLine()instead ofWaitForLogLine()These fixes should address the
System.InvalidOperationException : There is no currently active test.errors we started seeing after the previous upgrade attempt.Fixes #2684 (probably...)