feat: Add new configuration options for logging. #1880

[tippmar-nr]

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Adds new configuration options for logging in the .NET agent, to enable control over max file size, number of log files retained and the log rollover strategy (by size or by day). Note that .NET Profiler logging is unaffected by these configuration options.

Adds 3 new optional attributes to the <log> element in newrelic.config:

• logRollingStrategy - possible values are size and day, defaulting to size if not specified.
• maxLogFiles - an integer specifying the maximum number of log files to retain, defaulting to 4 if not specified. A value of 0 will retain all log files.
• maxLogFileSizeBytes - an integer specifying the maximum log file size in bytes, defaulting to 50MB. Only valid when logRollingStrategy is size. A value of 0 specifies that there is no maximum log file size.

Adds 3 new environment variables that will override the new attributes above if specified:

• NEW_RELIC_LOG_ROLLING_STRATEGY
• NEW_RELIC_LOG_MAX_FILES
• NEW_RELIC_LOG_MAX_FILE_SIZE_BYTES

Resolves #1880.

Documentation preview is at https://deploy-preview-16283--docs-website-netlify.netlify.app/docs/apm/agents/net-agent/configuration/net-agent-configuration/#log-logRollingStrategy

Author Checklist

• Unit tests, Integration tests, and Unbounded tests completed
• Performance testing completed with satisfactory results (if required)

Reviewer Checklist

• Perform code review
• Pull request was adequately tested (new/existing tests, performance tests)

[nrcventura]

We might want to clarify that this only applies to managed agent logs, and that profiler logs are not affected by these settings. I don't know if that information is best placed in this PR description, in the configuration.xsd, or elsewhere.

[chynesNR]

Looks good!

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 15.21739% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (d4372ca) to head (b49153a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2264      +/-   ##
==========================================
+ Coverage   81.30%   81.33%   +0.02%     
==========================================
  Files         396      397       +1     
  Lines       24748    24755       +7     
  Branches     2993     2995       +2     
==========================================
+ Hits        20122    20135      +13     
+ Misses       3847     3841       -6     
  Partials      779      779              

Files	Coverage Δ
.../NewRelic/Agent/Core/Logging/LoggerBootstrapper.cs	75.77% <87.50%> (-0.48%)	⬇️
src/Agent/NewRelic/Agent/Core/Config/ILogConfig.cs	0.00% <0.00%> (ø)
.../NewRelic/Agent/Core/Config/ConfigurationLoader.cs	82.83% <0.00%> (ø)

... and 4 files with indirect coverage changes