Dockerized mysql test dependencies #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
added
the
testing
|
jenkins retest this |
jaffinito
approved these changes
Sep 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #128 by adding a Dockerfile and associated docker-compose.yml entry to provide a MySQL database for use by the unbounded integration tests for our MySQL instrumentation.
Some minor changes were required to the test assertions to get the tests to pass, mostly due to database name case sensitivity. These changes don't change the logic of the tests.
This PR also cleans up some cruft from the test application that connects to the MySQL DB.
Testing
The unbounded integration tests pass locally and we'll make sure they pass in our internal CI before merging this PR.
Changelog
N/A