log4net to Serilog: Log format cleanup / rework #1672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues with log formatting, particularly in the Audit log output. Added another Serilog package to help with defining the log format similarly to the way we did with log4net.
Modified the various
XxxFormat()
methods to pass the format string and args through to Serilog, which ensures proper formatting of the string especially when the format string contains embedded JSON.Also re-worked the guard checks in
Logger.cs
andLog.cs
so that the check is made at the lowest level.