Skip to content

feat: Implement simple in-memory Serilog sink. #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2023
Merged

feat: Implement simple in-memory Serilog sink. #1657

merged 2 commits into from
May 23, 2023

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented May 22, 2023 •
edited
Loading

Description

  • Adds a simple in-memory Serilog sink using a ConcurrerntQueue for storage and to handle threading.

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

tippmar-nr
tippmar-nr approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jaffinito jaffinito marked this pull request as ready for review May 23, 2023 17:20
@jaffinito jaffinito requested review from a team, nrcventura, nr-ahemsath and chynesNR May 23, 2023 17:20
@jaffinito jaffinito merged commit 29d5c82 into feature/log4net-to-serilog May 23, 2023
@jaffinito jaffinito deleted the jaffinito/implement-in-memory-sink branch May 23, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tippmar-nr tippmar-nr tippmar-nr approved these changes

@nrcventura nrcventura Awaiting requested review from nrcventura

@nr-ahemsath nr-ahemsath Awaiting requested review from nr-ahemsath

@chynesNR chynesNR Awaiting requested review from chynesNR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
.NET Vulnerability Management
Development

Successfully merging this pull request may close these issues.
2 participants
@jaffinito @tippmar-nr