-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Adds minimal support for Devart Oracle client. #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @PhenX, thanks so much for your submission! Typically when we add new instrumentation, we add integration tests for it. Would you be comfortable taking that on, or would you like us to do it? We'd be happy to, but it may take a few days for us to get to it. |
@chynesNR thank you for your quick answer, I'll give it a try, and take inspiration from the other SQL instrumentations. I'll tell you if it is too much for me. |
I can't find integration tests for Oracle, I think I won't be able to start from scratch, feel free to handle it :) |
@PhenX - No worries! I should have time to get to it this week. |
Hello @chynesNR any news on this ? :) |
Hi @PhenX - so sorry for the delay! Our goal is to get it done this week, but if not, we'll merge this and add a ticket to the backlog for the integration tests. I think this is a low-risk change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low risk change. Going to merge without integration tests and add a backlog item to add them at a later date.
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 74.85% 74.87% +0.01%
==========================================
Files 408 408
Lines 25602 25602
==========================================
+ Hits 19164 19169 +5
+ Misses 6438 6433 -5 |
BEGIN_COMMIT_OVERRIDE
feat: Adds minimal support for Devart Oracle client.
END_COMMIT_OVERRIDE
Description
This adds support for auto instrumentation for the Devart Oracle driver
Author Checklist
Reviewer Checklist