test: Added unit tests for HttpCollectorWire. #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath and
chynesNR
…f a relatively recent version of Moq.
chynesNR
reviewed
Apr 20, 2023
nrcventura
reviewed
Apr 20, 2023
...t/UnitTests/CompositeTests/CrossAgentTests/DistributedTracing/TraceContextCrossAgentTests.cs
Outdated
Show resolved
Hide resolved
….Core.Internal.ForEach that should never have been used in the first place.
nrcventura
previously approved these changes
Apr 21, 2023
chynesNR
previously approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 73.03% 74.91% +1.88%
==========================================
Files 408 408
Lines 25581 25577 -4
==========================================
+ Hits 18682 19162 +480
+ Misses 6899 6415 -484
|
chynesNR
previously approved these changes
Apr 21, 2023
nrcventura
previously approved these changes
Apr 21, 2023
chynesNR
approved these changes
Apr 21, 2023
nrcventura
reviewed
Apr 21, 2023
nrcventura
approved these changes
Apr 21, 2023
tippmar-nr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
Adds unit tests for
HttpCollectorWire. Also adds theMoqmocking framework toCore.UnitTest.Minor refactoring in
HttpCollectorWire.Also updatesCastle.Coreto v4.4.1 andCastle.Windsorto v5.1.1 everywhere in the application, to resolve dependency conflicts onMoq. This change may carry additional risk, so we may end up needing to revert it if there are issues with unit or integration tests or if we feel the risk is simply too great.Author Checklist
Reviewer Checklist