fix: fix regression in NLog local decoration when logging objects as parameters #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments came from a misunderstanding about Visual Studio's display of an object when you mouse over it coming from ToString().
Also implement LogWithParam in other adapters even though we might not use them yet
chynesNR
reviewed
Mar 23, 2023
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/NLogLogging/NLogWrapper.cs
Outdated
Show resolved
Hide resolved
jaffinito
reviewed
Mar 24, 2023
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/NLogLogging/NLogWrapper.cs
Show resolved
Hide resolved
...edApplications/Common/MultiFunctionApplicationHelpers/MultiFunctionApplicationHelpers.csproj
Show resolved
Hide resolved
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/NLogLogging/NLogWrapper.cs
Outdated
Show resolved
Hide resolved
Also removed TODO from MFAH.csproj. I want to make that correction as part of a larger set of improvements to how we associate CMF TFMs with library versions.
nr-ahemsath
requested review from
a team,
jaffinito,
nrcventura,
JcolemanNR,
chynesNR and
tippmar-nr
chynesNR
reviewed
Mar 24, 2023
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/Logging/LoggingHelpers.cs
Show resolved
Hide resolved
chynesNR
approved these changes
Mar 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
- Coverage 72.98% 72.98% -0.01%
==========================================
Files 408 408
Lines 25459 25462 +3
==========================================
+ Hits 18582 18583 +1
- Misses 6877 6879 +2
|
JcolemanNR
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See bug #1459. PR #1393 improved NLog local decoration coverage, but broke logging of objects as parameters, e.g.:
_logger.LogDebug("Start Request: {@request}", request);This PR fixes the issue and adds test coverage for the parameterized logging case.
Author Checklist
Reviewer Checklist