Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Postgres v4.1 through v7 #1363

Merged
merged 14 commits into from
Jan 27, 2023

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jan 26, 2023

Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.

Description

Updates instrumentation configuration and unbounded integration tests to support all current versions of Postgres for .NET (npgsql) NuGet v4.0.0 through 7.0.1

Author Checklist

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #1363 (ffbbebd) into main (1f60bf5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   71.65%   71.65%   -0.01%     
==========================================
  Files         459      459              
  Lines       30546    30546              
==========================================
- Hits        21889    21888       -1     
- Misses       8657     8658       +1     
Impacted Files Coverage Δ
...c/Agent/Core/DataTransport/DataStreamingService.cs 82.44% <0.00%> (-0.65%) ⬇️
src/Agent/NewRelic/Agent/Core/Time/Scheduler.cs 81.50% <0.00%> (+2.05%) ⬆️

@tippmar-nr tippmar-nr marked this pull request as ready for review January 26, 2023 19:34
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tippmar-nr tippmar-nr merged commit d1cedff into main Jan 27, 2023
@tippmar-nr tippmar-nr deleted the tippmar-nr/postgres-instrumentation-bug-fix branch January 27, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants