Resolve issue where more logs were forwarded than desired from MEL #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimum log level for MEL.
JcolemanNR
commented
Sep 1, 2022
JcolemanNR
commented
Sep 1, 2022
...lic/Agent/Extensions/Providers/Wrapper/MicrosoftExtensionsLogging/MicrosoftLoggingWrapper.cs
Outdated
Show resolved
Hide resolved
chynesNR
reviewed
Sep 1, 2022
...lic/Agent/Extensions/Providers/Wrapper/MicrosoftExtensionsLogging/MicrosoftLoggingWrapper.cs
Outdated
Show resolved
Hide resolved
jaffinito
approved these changes
Sep 2, 2022
nr-ahemsath
reviewed
Sep 2, 2022
|
Performance test results: With Changes (additional log enabled check): Without changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our instrumentation point for Microsoft Extensions Logging in agent log forwarding is invoked before any of the built in log level filtering has taken place. Due to this, logs with a lower level than what was configured in MEL were being forwarded to New Relic.
These changes resolve that issue by querying MEL to see if the level of observed log events are enabled or disabled.
Resolves #1230
Author Checklist
Reviewer Checklist