Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename linux install packages #1180

Merged

Conversation

nr-ahemsath
Copy link
Member

@nr-ahemsath nr-ahemsath commented Jul 6, 2022

Description

Resolves #1128

  • Linux install packages are renamed from newrelic-netcore20-agent to newrelic-dotnet-agent
  • The packages are now marked as conflicting with and replacing (.deb) or obsoleting (.rpm) the older package name, preventing both from being installed on the same system
  • User data (newrelic.config and any custom .xml instrumentation files) will be migrated from the old package to the new when upgrading
  • Replaced other miscellaneous appearances of the string netcore20 throughout our codebase as appropriate

I tested upgrading from a previous installation of newrelic-netcore20-agent to the new newrelic-dotnet-agent package in the following cases:

  • On Ubuntu 20.04:
    • Upgrade using apt install
    • Upgrade using dpkg -i
  • On Centos 7:
    • Upgrade using yum install
    • Upgrade using rpm -U

There are a couple of documentation changes associated with this PR that should also be reviewed:

  1. General agent documentation changes: https://github.com/nr-ahemsath/docs-website/compare/develop...nr-ahemsath:docs-website:update-dotnet-agent-linux-package-names?expand=1
  2. 9.x to 10.x agent migration guide: https://github.com/vuqtran88/docs-website/blob/dotnet-agent-10x-migration-guide/src/content/docs/apm/agents/net-agent/getting-started/9x-to-10x-agent-migration-guide.mdx#linux-installer-packages-name-change

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed Testing as described above
  • Performance testing completed with satisfactory results (if required) N/A
  • Agent Changelog or Lambda Agent changelog updated

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)
  • Review Changelog

@nr-ahemsath nr-ahemsath added this to the Major Release 10.0 milestone Jul 6, 2022
@nr-ahemsath nr-ahemsath marked this pull request as draft July 7, 2022 16:49
@nr-ahemsath nr-ahemsath marked this pull request as ready for review July 7, 2022 21:44
Copy link
Contributor

@vuqtran88 vuqtran88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually built all linux packages locally and inspected their content and they all look good. 🚢 it !

@nr-ahemsath nr-ahemsath merged commit 5bec1fd into major-release-10-feature-branch Jul 8, 2022
@nr-ahemsath nr-ahemsath deleted the rename-linux-install-packages branch July 8, 2022 20:47
vuqtran88 added a commit that referenced this pull request Jul 18, 2022
* Updates gRPC Google.Protobuf to latest version (#1137)

* Updates gRPC Google.Protobuf to latest version

* Include InfiniteTracing tests in all_solutions.yml

* Drop eol frameworks tests (#1134)

* Modified the MockNewRelic to work with the latest .net core (net6)
Dropped tests for EOL frameworks (.Net Core < 3.0 and .Net Framework < 4.6.2)

* fixed MockNewRelic

* Fixed an issue with the MockCollector's response that causes client could not parse.

* Removes test coverage for EOLed frameworks in the Unbounded integration tests solution.

* fixed the BasicMvcCoreApplication test app from the UnboundedApplications.

* cleanup and add back test for Nlog v4.5.9.

* Migrate agent to target net462 (#1143)

* WIP

* WIP

* WIP

* Identified needed profiler code change

* Update workflow

* Update profiler to detect updated minimum .NET versions (#1153)

* Update minimum version detection for profiler

* Update workflow to pull the correct CLR version for ARM profiler build

* Update linux profiler builds

* Remove deprecated test frameworks, update documentation

* Remove scriptable installers from build and deploy process (#1170)

* First pass at removing everything involved in building and deploying the scriptable installers

* Update CHANGELOG.md

* Add MEL logging support for .Net Framework apps. (#1172)

* Include MicrosoftExtensionsLogging wrapper in the newrelichome_x64 directory.

* include MicrosoftExtensionsLogging wrapper in for all FW agent deployment packages.

* include MicrosftExtensionsLogging wrapper in FW agent in the msi installer.

* Add FW tests for Microsoft.Extensions.Logging logging support.

* only test MEL on net48.
fix variable names.

* Update CHANGELOG.md

* Fix unbounded integration test user secrets bug (#1178)

* Update Shared.csproj to use the latest Microsoft.Extensions.Configuration version for both .Net Core and .Net Framework

* Microsoft.Extensions.Configuration.* ver 6.0.x don't work for the AspNetCoreMvcCoreFrameworkTests so downgrade them all down to 2.2.0.

* Remove CastleMonoRail2 instrumentation. (#1177)

* Remove CastleMonoRail2 instrumentation.

* Add logic in the profiler to not load Castle Mono Rail instrumentation xml.
Add logic in the msi installer to delete Castle Mono Rail instrumentation.

* Update CHANGELOG.md

* Update src/Agent/CHANGELOG.md

Co-authored-by: Alex Hemsath <[email protected]>

Co-authored-by: Alex Hemsath <[email protected]>

* Report infinite tracing (and other) configuration in connect/agent_settings payload (#1174)

* Ignore SMSvcHost.exe (#1182)

* Ignore SMSvcHost.exe

* changelog

* updates _profilerBuild directory with new profiler

Co-authored-by: Josh Coleman <[email protected]>

* Rename linux install packages (#1180)

* Initial renaming

* Fix one file, debs are building now

* Prevent old and new packages from being installed at the same time

* Add migration of previous user data for .deb

* Handle data migration in RPM case

* Update package deploy script

* Find and replace some other uses of netcore20

* Update CHANGELOG.md

Co-authored-by: Vu Tran <[email protected]>

* Consolidate and rename Windows installation asset filenames (#1187)

* Consolidate framework and core zip archives

* Update download site artifact and readme

* Use semantic version for all download site artifacts

* SemVer version for linux packages

* Update linux package deploy for semver versions

* Update download site deploy to account for MSI name format change

* Update changelog and remove commented out code

* .NET 5 is the newest available by default on the CI runner

* Improve Linux package user data migration process (#1190)

* Update CHANGELOG.md (#1192)

* Update CHANGELOG.md

Add text in the changelog to call out the updates on target runtime.  Someone could word it better; it's good to have it visible in the changelog in case users did not click on the migration guide right away.  

Currently the logging changes is not showing up in this changelog.. maybe it's already in the main branch?

* Adds log.level to level change to changelog

* Update minimum supported versions wording, update migration link

Co-authored-by: Jacob Affinito <[email protected]>
Co-authored-by: Josh Coleman <[email protected]>

Co-authored-by: Jacob Affinito <[email protected]>
Co-authored-by: Vu Tran <[email protected]>
Co-authored-by: Alex Hemsath <[email protected]>
Co-authored-by: Angela Tan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants