Skip to content

Add .NET 7 Unit Test Build Target #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tippmar-nr opened this issue Jun 20, 2023 · 2 comments
Closed

Add .NET 7 Unit Test Build Target #1731

tippmar-nr opened this issue Jun 20, 2023 · 2 comments

Comments

@tippmar-nr
Copy link
Member

Describe the story, please be clear on scope of the story.

Unit tests currently run only against a .NET Framework 462 build target, but we have numerous bits of code that are excluded from .NET Framework builds and thus are not covered by unit tests at present.

Add a .NET 7 build target to the Core.UnitTest project and modify existing tests so that they pass under both TFMs. A POC branch for this change is at https://github.com/newrelic/newrelic-dotnet-agent/tree/poc/net-7-unit-tests - in that branch, there are around 100 failing unit tests that need to be investigated. If a test is only applicable to .NET Framework, exclude it from .NET 7 builds. Otherwise, make changes as needed to ensure that the tests pass.

Acceptance Criteria

Unit Tests should execute against a .NET Framework build target as well as a .NET 7 build target. All unit tests should pass.

Estimates

Please provide initial t-shirt size
M

@workato-integration
Copy link

@chynesNR
Copy link
Member

chynesNR commented Aug 4, 2023

Completed in: #1778

@chynesNR chynesNR closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants