Skip to content

feat: Switch web vitals library to attribution build #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 26, 2024
Merged

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Mar 18, 2024

Report extra attributes for each vital using web vital library's attribution build.

Overview

Most "potentially-helpful" debugging information offered by CWV's attribution build is now included with the PageViewTiming event nodes. Many of them have the same property name as given by CWV.
Note that we may remap some or all of them to our own standardized names in the future. At the present, they can be NRQL for using those attribute names directly, like SELECT firstByteToFCP FROM PageViewTiming WHERE timingName = 'firstContentfulPaint'.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-191642

  • Untracked chore: fix test matcher not considering Android versions

Testing

Jest tests for each indiv vital & pvt component updated.

Copy link

github-actions bot commented Mar 18, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.28 kB / 11.27 kB (gzip) 32.28 kB / 11.27 kB (gzip) 0% / 0% (gzip)
lite async-chunk 46.67 kB / 15.33 kB (gzip) 50.52 kB / 16.34 kB (gzip) 8.25% / 6.59% (gzip)
pro loader 51.45 kB / 17.49 kB (gzip) 51.45 kB / 17.49 kB (gzip) 0% / -0.01% (gzip)
pro async-chunk 88.05 kB / 27.04 kB (gzip) 91.91 kB / 28.06 kB (gzip) 4.39% / 3.78% (gzip)
spa loader 60.01 kB / 20.11 kB (gzip) 60.01 kB / 20.11 kB (gzip) 0% / 0% (gzip)
spa async-chunk 102.26 kB / 31.2 kB (gzip) 106.12 kB / 32.24 kB (gzip) 3.77% / 3.34% (gzip)
lite-polyfills loader 127.5 kB / 40.98 kB (gzip) 127.5 kB / 40.98 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 60.19 kB / 17.58 kB (gzip) 63.95 kB / 18.5 kB (gzip) 6.26% / 5.29% (gzip)
pro-polyfills loader 147.53 kB / 46.91 kB (gzip) 147.53 kB / 46.91 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 122.51 kB / 31.95 kB (gzip) 126.28 kB / 32.96 kB (gzip) 3.08% / 3.13% (gzip)
spa-polyfills loader 155.55 kB / 49.03 kB (gzip) 155.55 kB / 49.02 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 139.01 kB / 36.43 kB (gzip) 142.78 kB / 37.41 kB (gzip) 2.72% / 2.68% (gzip)

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.60%. Comparing base (fb4e36b) to head (f05227a).
Report is 3 commits behind head on main.

Files Patch % Lines
src/common/vitals/interaction-to-next-paint.js 60.00% 2 Missing ⚠️
src/features/page_view_event/aggregate/index.js 0.00% 2 Missing ⚠️
src/features/page_view_timing/aggregate/index.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   80.54%   80.60%   +0.06%     
==========================================
  Files         154      154              
  Lines        7058     7070      +12     
  Branches     1398     1397       -1     
==========================================
+ Hits         5685     5699      +14     
+ Misses       1169     1168       -1     
+ Partials      204      203       -1     
Flag Coverage Δ
integration-tests 89.90% <88.00%> (-0.01%) ⬇️
unit-tests 58.54% <91.17%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 20, 2024

Static Badge

Last ran on March 25, 2024 14:37:19 CDT
Checking merge of (f05227a) into main (fb4e36b)

@cwli24 cwli24 merged commit f36acbc into main Mar 26, 2024
@cwli24 cwli24 deleted the cwv-attribution branch March 26, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants