-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Switch web vitals library to attribution build #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 80.54% 80.60% +0.06%
==========================================
Files 154 154
Lines 7058 7070 +12
Branches 1398 1397 -1
==========================================
+ Hits 5685 5699 +14
+ Misses 1169 1168 -1
+ Partials 204 203 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Report extra attributes for each vital using web vital library's attribution build.
Overview
Most "potentially-helpful" debugging information offered by CWV's attribution build is now included with the
PageViewTiming
event nodes. Many of them have the same property name as given by CWV.Note that we may remap some or all of them to our own standardized names in the future. At the present, they can be NRQL for using those attribute names directly, like
SELECT firstByteToFCP FROM PageViewTiming WHERE timingName = 'firstContentfulPaint'
.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-191642
Testing
Jest tests for each indiv vital & pvt component updated.