-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Calculate New Relic time in the agent #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
a56d1ca
to
f278e24
Compare
f278e24
to
eaf66d2
Compare
eaf66d2
to
ae47ff9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 80.19% 80.42% +0.22%
==========================================
Files 154 154
Lines 7010 7044 +34
Branches 1389 1386 -3
==========================================
+ Hits 5622 5665 +43
+ Misses 1170 1163 -7
+ Partials 218 216 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 85887c8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General concept looks good, g2g when tests are done
Migrating the process of time-stamping harvested data to the agent. The agent will utilize the date and time reported by the ingest pipeline during the RUM call as well as browser network and timing stats to derive a server time offset that can be applied to harvested data as event occur. This will improve the ability to visualize the harvested data on a timeline within New Relic UI.
Overview
Adding a new time keeper class to the agent that will utilize the RUM network call and the resource performance APIs to calculate the server time offset. This can then be used by features and other aspects of the agent to correct an absolute timestamp from browser time to server time and convert a time value relative to page origin to a timestamp that accounts for the server time offset.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-222414
Testing