feat: Remove unused data from session trace requests #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data defined by APM agents and the customer will no longer be included in session trace requests since the data is not consumed downstream and can result in 414 errors in cases where the custom data would cause the URL to exceed the maximum length of 8,192 bytes.
Overview
Removed the
ja
,ua
, andat
query parameters from the session trace network requests. These parameters, especiallyja
, could grow so large that it would cause the resulting URL to exceed the 8192 bytes limit. This data was never actually consumed downstream and doesn't need to be sent on any session trace request.Related Issue(s)
https://issues.newrelic.com/browse/NEWRELIC-7997
Testing
The integration tests have been updated to remove reliance on these properties. To test locally, build the agent and inject it into a test project. Verify in NR that session traces are still getting created.
BEGIN_COMMIT_OVERRIDE
feat: Remove unused data from session trace requests
END_COMMIT_OVERRIDE