-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Remove FID #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove FID #1319
Conversation
Preserve `firstInteraction` by detecting the first INP instead of FID event.
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 88.70% 88.66% -0.05%
==========================================
Files 170 171 +1
Lines 7331 7340 +9
Branches 1488 1487 -1
==========================================
+ Hits 6503 6508 +5
Misses 716 716
- Partials 112 116 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
First Input Delay (FID) has been deprecated and replaced by Interaction To Next Paint (INP). PageViewTiming events for first interactions are preserved by detecting the first
first-input
event and will no longer output value for thefirstInputDelay
andloadState
attributes. For more info on PageViewTiming, see https://docs.newrelic.com/docs/browser/new-relic-browser/page-load-timing-resources/pageviewtiming-async-or-dynamic-page-details/. For more info on INP and the FID deprecation, see https://web.dev/articles/inp.Overview
In this PR, we are proceeding with the removal of FID related logic from the browser agent.
Notes:
firstInteraction
timing event should continue to be detected as-is, with the exception of no longer collecting or generating values forfirstInputDelay
andloadState
attributes. Supported in Chrome, Edge, Firefox and Android. Not supported on Safari and iOS (see PerformanceEventTming browser compatibility)Related Issue(s)
https://new-relic.atlassian.net/browse/NR-355558
Testing
Updated existing tests that dealt with FID.
Added unit tests for first interaction.
Manually tested