-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Refactor feature storages #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ect jserror to aggregate-base
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 88.49% 89.08% +0.59%
==========================================
Files 169 169
Lines 7379 7351 -28
Branches 1510 1476 -34
==========================================
+ Hits 6530 6549 +19
+ Misses 725 682 -43
+ Partials 124 120 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bfe23a4
to
698a696
Compare
Co-authored-by: ptang-nr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voting to approve, to the best of my current understanding 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, should be released in a standalone release due to impact, so keep in mind the release tree state before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This change rewrites the way every feature stores its respective data to optimize runtime overhead, improve agent internals efficiency, and standardize the way storages are referenced and called.
Overview
This PR also plays a part in preparing for centralizing the harvester by providing a common interface that it can tap into when requesting harvest data on interval. It follows the model as diagramed here: https://whimsical.com/centralized-harvesting-manager-flow-BCxxiTMtWJAqpLL56A7zys
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-321653
Testing